Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various minor fixups #1160

Merged
merged 3 commits into from
Dec 2, 2019
Merged

Various minor fixups #1160

merged 3 commits into from
Dec 2, 2019

Conversation

asomers
Copy link
Member

@asomers asomers commented Dec 1, 2019

Fix various minor TODOs and FIXMEs in the code.

@asomers
Copy link
Member Author

asomers commented Dec 1, 2019

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 2, 2019

Merge conflict

@asomers
Remove some obsolete comments.
96ca082 
ignore really is the correct things to do for these doc tests.
compile_fail should only be used for examples that demonstrate a compile
failure by design, not for stuff that only works on one platform.
@asomers
Reenable a test that had been disabled due to old CI infrastructure
0f7be3e
@asomers
ScmCredentials now wraps UnixCredentials instead of libc::ucred
6cc90b3
@asomers
Copy link
Member Author

asomers commented Dec 2, 2019

bors r+

bors bot added a commit that referenced this pull request Dec 2, 2019
@bors @asomers
Merge #1160
948926a 
1160: Various minor fixups r=asomers a=asomers

Fix various minor TODOs and FIXMEs in the code.

Co-authored-by: Alan Somers <asomers@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 2, 2019

Build failed

  • FreeBSD 11.2

@asomers
Copy link
Member Author

asomers commented Dec 2, 2019

The builds all succeeded. I don't know what bors is complaining about.

bors retry

bors bot added a commit that referenced this pull request Dec 2, 2019
@bors @asomers
Merge #1160
1364575 
1160: Various minor fixups r=asomers a=asomers

Fix various minor TODOs and FIXMEs in the code.

Co-authored-by: Alan Somers <asomers@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 2, 2019

Build succeeded

@bors bors bot merged commit 6cc90b3 into nix-rust:master Dec 2, 2019
@asomers asomers deleted the fixme branch December 2, 2019 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asomers