Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RISC-V support on GNU/Linux #1176

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Add RISC-V support on GNU/Linux #1176

merged 1 commit into from
Feb 2, 2020

Conversation

msizanoen1
Copy link
Contributor

No description provided.

@asomers
Copy link
Member

asomers commented Jan 9, 2020

How does one build this? Does rustup include a risc-v toolchain now?

@msizanoen1
Copy link
Contributor Author

No but libc and libstd are ported.
You can get a RISC-V cross toolchain and use xargo or cargo's -Zbuild-std.

@msizanoen1
Copy link
Contributor Author

This is the PR for building rust libstd on CI: rust-lang/rust#68037
After it is merged you can install it from rustup.

@msizanoen1 msizanoen1 mentioned this pull request Jan 9, 2020
Closed
@asomers
Copy link
Member

asomers commented Jan 11, 2020

What exactly does this PR accomplish? Is there more to it than those handfuls of constants?

@msizanoen1
Copy link
Contributor Author

That's everything needed to make it compile on RISC-V.

asomers
asomers approved these changes Feb 2, 2020
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this change because it is, at the very least, harmless to supported platforms. But we can't officially support RISC-V without a CI solution.

bors r+

bors bot added a commit that referenced this pull request Feb 2, 2020
@bors @msizanoen1
Merge #1176
d401c6f 
1176: Add RISC-V support on GNU/Linux r=asomers a=msizanoen1



Co-authored-by: msizanoen1 <qtmlabs@protonmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 2, 2020

Build succeeded

@bors bors bot merged commit 10e69db into nix-rust:master Feb 2, 2020
@msizanoen1 msizanoen1 deleted the riscv branch February 3, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msizanoen1 @asomers @andreas-schwab