Fix unaligned casting of cmsg data to af_alg_iv #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebpom
changed the title
|
Thanks for the fix. Might I ask how you found the problem? Also, could you please add a CHANGELOG entry? |
|
Sure, that was pretty easy with clippy. BTW, few other things are treated as errors by clippy as well. It would make sense to add clippy check as a CI step. |
glebpom
force-pushed
the
af-alg-unaligned-access-fix
branch
from
1879eef to
75ca048
Compare
glebpom
force-pushed
the
af-alg-unaligned-access-fix
branch
from
75ca048 to
0a99945
Compare
bors bot
added a commit
that referenced
this pull request
Apr 14, 2020
1206: Fix unaligned casting of cmsg data to af_alg_iv r=asomers a=glebpom Casting a pointer to `cmsg_data` to `af_alg_iv` is incorrect since it's not properly aligned. As of the [`cmsg` man page](http://man7.org/linux/man-pages/man3/cmsg.3.html) "Applications should not cast it to a pointer type matching the payload, but should instead use memcpy(3) to copy data to or from a suitably declared object." Co-authored-by: Gleb Pomykalov <gleb@lancastr.com>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casting a pointer to
cmsg_datatoaf_alg_ivis incorrect since it's not properly aligned. As of thecmsgman page "Applications should not cast it to a pointer type matching the payload, but should instead use memcpy(3) to copy data to or from a suitably declared object."