Fix fork test and enable doc test #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces `println!` with raw `libc::write`. `println!` isn't guaranteed to be async-signal-safe, and almost certainly *isn't* due to internal buffering and locking. Adds a call to `libc::_exit` in the child arm, so that it doesn't fall through and start executing the parent code. Adds a call to `waitpid` in the parent arm, to clean up the child process. Removes the `no_run` directive, so that it's run in the doc tests.
asomers
reviewed
Jul 9, 2021
| /// } | ||
| /// Ok(ForkResult::Child) => { | ||
| /// // Unsafe to use `println!` (or `unwrap`) here. See Safety. | ||
| /// write(libc::STDOUT_FILENO, "I'm a new child process\n".as_bytes()).ok(); |
There was a problem hiding this comment.
Should you explicitly nul-terminate this string?
There was a problem hiding this comment.
No, I don't think so. The underlying syscall takes an explicit length parameter (which the nix wrapper provides for us)
There was a problem hiding this comment.
Yeah, that's right. Because you're writing to stdout, there's no need to nul-terminate. stdout never ends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
println!with rawlibc::write.println!isn't guaranteedto be async-signal-safe, and almost certainly isn't due to internal
buffering and locking.
Adds a call to
libc::_exitin the child arm, so that it doesn't fallthrough and start executing the parent code.
Adds a call to
waitpidin the parent arm, to clean up the childprocess.
Removes the
no_rundirective, so that it's run in the doc tests.