Implement Extend and From/IntoIterator for SigSet #1553
Conversation
magicant
force-pushed
the
sigset_iterator
branch
from
d46271c to
1741702
Compare
src/sys/signal.rs
Outdated
| @@ -1180,6 +1214,26 @@ mod tests { | |||
| }).join().unwrap(); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_extend() { | |||
There was a problem hiding this comment.
What's the difference between this and the original test? I don't see any. Could you please move it back to its original location?
There was a problem hiding this comment.
It seemed to me that existing tests were arranged in the order of implementation, so I reordered this test as I implemented Extend. But if you prefer minimizing the diff, I have no problem doing so. 598f6a6
|
|
||
| ### Removed | ||
|
|
||
| - Removed `SigSet::extend` in favor of `<SigSet as Extend<Signal>>::extend`. |
There was a problem hiding this comment.
I would put this in the "Changed" section rather than "Removed"
|
This looks good to me, but you'll have to rebase on master to fix CI, and squash your commits before merging. |
magicant
force-pushed
the
sigset_iterator
branch
from
d1dcaee to
97efade
Compare
|
Rebased & squashed. Thank you! @asomers |
magicant
force-pushed
the
sigset_iterator
branch
from
97efade to
a24f390
Compare
|
Rebased again to resolve the conflict in CHANGELOG.md. |
|
@magicant can you rebase? |
magicant
force-pushed
the
sigset_iterator
branch
from
a24f390 to
2196824
Compare
|
Sure. @rtzoeller |
|
bors r+ |
No description provided.