Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore conversions from ip v4/6 Sockaddr types to std::net equivalents. #1711

Merged
merged 1 commit into from
May 3, 2022
Merged

Restore conversions from ip v4/6 Sockaddr types to std::net equivalents. #1711

merged 1 commit into from
May 3, 2022

Conversation

khuey
Copy link
Contributor

@khuey khuey commented Apr 28, 2022

Fixes #1710

@asomers
Copy link
Member

asomers commented Apr 28, 2022

How about a mention in the Added section of CHANGELOG?

@rtzoeller
Copy link
Collaborator

@khuey can you rebase to fix the CHANGELOG conflict? I updated the file with the expected format in another PR.

@khuey khuey force-pushed the sockaddrin_std_conv branch from 056cdc7 to 024c0d7 Compare May 2, 2022 15:53
@khuey
Copy link
Contributor Author

khuey commented May 2, 2022

@khuey can you rebase to fix the CHANGELOG conflict? I updated the file with the expected format in another PR.

Done

asomers
asomers approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors r+

@bors
Copy link
Contributor

bors bot commented May 3, 2022

Build succeeded:

@bors bors bot merged commit 3109a6d into nix-rust:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InetAddr replacements are not convertible to libstd types?
3 participants
@khuey @asomers @rtzoeller