Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable socket and select on redox #2012

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Enable socket and select on redox #2012

merged 3 commits into from
Apr 5, 2023

Conversation

coolreader18
Copy link
Contributor

No description provided.

@coolreader18
Copy link
Contributor Author

Ping; would someone be able to review this?

@asomers
Copy link
Member

asomers commented Mar 29, 2023

I don't have a lot of time left for Nix these days, but I think I'll be able to do this and a few other PRs on Sunday.

asomers
asomers reviewed Apr 3, 2023
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this looks good. Would you please add a CHANGELOG entry?

asomers
asomers approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Apr 3, 2023
@bors @coolreader18
Merge #2012
6e3b9c5 
2012: Enable socket and select on redox r=asomers a=coolreader18



Co-authored-by: Noa <coolreader18@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 3, 2023

Build failed:

@coolreader18
Copy link
Contributor Author

Seems like a fluke?

@coolreader18
Copy link
Contributor Author

bors retry

@bors
Copy link
Contributor

bors bot commented Apr 5, 2023

🔒 Permission denied

Existing reviewers: click here to make coolreader18 a reviewer

@coolreader18
Copy link
Contributor Author

worth a shot :P

@asomers
Copy link
Member

asomers commented Apr 5, 2023

bors retry

@bors
Copy link
Contributor

bors bot commented Apr 5, 2023

Build succeeded:

@bors bors bot merged commit 1bfbb03 into nix-rust:master Apr 5, 2023
@coolreader18 coolreader18 deleted the redox-net branch April 5, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolreader18 @asomers