update libc to 0.2.2 #210
Closed
update libc to 0.2.2 #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this breaks CI. What broke on ARM? I guess upgrading libc is not going to be fun... |
|
Here are the build errors: libc c_char on ARM Linux was i8 but is now u8: I'll look into the errors on mac and 1.1.0, I only tested with linux and 1.4.0 before. |
|
Closing this one in favor of #219. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nix is broken on nightly arm because of:
rust-lang/rust#29775
This fixes nix for arm nightly, but breaks on arm stable. Should work on x86 stable and nightly.
Maybe this could be put into a separate nightly branch that could be pointed to in Cargo.toml?