Relax lifetime requirements for FdSet::{insert, remove, contains} #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @SteveLauC |
asomers
force-pushed
the
fdset-lifetime
branch
from
a6ae905
to
352446a
Compare
|
Seems that these functions should also take a |
&AsFd doesn't work because there are 'static types, like std::fs::File, which implement AsFd.
asomers
force-pushed
the
fdset-lifetime
branch
from
352446a
to
347d5e3
Compare
SteveLauC
requested changes
Oct 1, 2023
SteveLauC
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2130