-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More cfg alias targets + disabled related clippy lint #2236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Why is there a need for those aliases? |
Yeah, they are currently not in use, should I revert this PR? I merged this PR because it is trivial and maybe there will be a use case for it in the future, when we don't want those target_os = "xxx" stuff and fully switch to aliases |
Yes, I think we should revert it , just so we can reenable that lint. I've seen that lint fire correctly before. |
|
I don't think we should use them at all, if they only cover single targets. Aliases like apple_family are useful because they combine multiple targets. But the |
This reverts commit e13a182.
This is my fault, I am sorry about it |
All good, just need to tweak my codegen script a bit. |
Adds the remaining supported platforms as cfg alias.
This PR also disables this lint.
Checklist:
CONTRIBUTING.md