refactor: impl EventFd::read/write with eventfd_read/write #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
force-pushed
the
eventfd_read/write
branch
from
23e2fb7
to
05b326b
Compare
asomers
approved these changes
Jan 7, 2024
Well, then I am not sure if we should merge this since I don't want to be in trouble like the one of #2146, let's me investigate the Glibc version where they were added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Implement
EventFd::read/writewithlibc::eventfd_read()/eventfd_write()functions instead of implementing them ourselves so that we can survive even when libc has its behavior changedChecklist:
CONTRIBUTING.md