Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: impl From<sigaction> for SigAction #2410

Merged
merged 1 commit into from
May 19, 2024
Merged

revert: impl From<sigaction> for SigAction #2410

merged 1 commit into from
May 19, 2024

Conversation

SteveLauC
Copy link
Member

What does this PR do

impl From<libc::sigaction> for SigAction is unsafe since there is no guarantee on the values stored in libc::sigaction, revert the implementation added in #2326.

Issue #2327 still needs to be resolved, some thoughts on it:

  1. impl TryFrom and check the values to ensure they are valid
  2. Define unsafe traits like unsafe trait UnsafeFrom/UnsafeInto

cc @AzariasB

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@SteveLauC SteveLauC added this pull request to the merge queue May 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 19, 2024
@SteveLauC SteveLauC added this pull request to the merge queue May 19, 2024
Merged via the queue into nix-rust:master with commit 1604723 May 19, 2024
36 checks passed
@SteveLauC SteveLauC deleted the revert/impl_From_libc_sigaction_for_SigAction branch May 19, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveLauC @asomers