Skip to content

Conversation

devnexen
Copy link
Contributor

No description provided.

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bugfix! This probably deserves a changelog entry, too. Could you please add that?

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"fix" is very vague. What did you fix? It's important to say whether you're fixing a compile-time issue or a runtime one. Also, your commit message should end with "Fixes #2641".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants