Replace ffi module by libc functions in mqueue.rs #392
Conversation
| const O_CREAT = 0o00000100, | ||
| const O_EXCL = 0o00000200, | ||
| const O_NONBLOCK = 0o00004000, | ||
| const O_CLOEXEC = 0o02000000, |
There was a problem hiding this comment.
Might be better to use the libc constants as the values in the enum?
There was a problem hiding this comment.
Yes, it would be better. I will change that.
It would be even better to use OFlag from fcntl.rs. But Oflag has more flags than are allowed for the mqueue functions. I suppose, the other flags would just be ignored if passed into the functions. And just to be safe we could warn about their usage in mqueue functions. I have not made my mind up yet, and this PR is just for getting rid of the ffi module. There is much more that could be done to clean up this module.
|
Changes generally look good. Probably run rustfmt on the file while your making changes (a few lines are getting a bit long and its nice to have consistent formatting). |
|
I'll have a look at rustfmt. I never used it before. (Maybe something for the conventions or contribution guidelines?) I'll let it run when the rest of this PR is done and add the changes in their own commit. |
|
I think this can be merged now. |
|
☔ The latest upstream changes (presumably #402) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Given that no further comments were made, I'll merge this tomorrow. |
|
📌 Commit 8ed5521 has been approved by |
Replace ffi module by libc functions in mqueue.rs This is almost finished. I still need to check if I introduced any breaking changes by changing signatures. I would want to record this in the change log, however, for that we still need to merge #391. - [x] update change log - [x] run rustfmt on `src/mqueue.rs`
|
☀️ Test successful - status |
This is almost finished. I still need to check if I introduced any breaking changes by changing signatures. I would want to record this in the change log, however, for that we still need to merge #391.
src/mqueue.rs