-
Notifications
You must be signed in to change notification settings - Fork 689
add unistd::getcwd and unistd::mkdir #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ac64273
implemented getcwd (returning Result<PathBuf>, reconciling all calls …
philippkeller b03d4e5
added test for getcwd, still not complete (needs to check also longer…
philippkeller 8b1828a
implemented mkdir, extended getcwd test to include long path names
philippkeller 8fbd8e9
made it running with rust 1.2.0: the code for getcwd is now an exact …
philippkeller c0a5785
fixed the trailing whitespaces
philippkeller 50693c1
added documentation for getcwd and mkdir, changed test so that it com…
philippkeller 37e4f97
rust 1.2.0 doesn't support expect, switched to proper match block
philippkeller 5f1e144
resolving all remarks by @posborne, fixed max line length=99, fixed r…
philippkeller 7dd12c6
fixed indentation
philippkeller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous example included
extern crate
declarations and this one doesn't. I think they are not required in general for$crate
(nix here).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is required. The doc says:
Since I need to do a
extern crate tempdir
I also need to do an extern crate nix here.I think you want to hint that all examples should have the same style, that's why I now changed the doc of
getcwd
to have the same syntax asmkdir
(including extern crate nix and an explicit main function)