Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #480 and add one test case for that. #484

Closed
wants to merge 0 commits into from
Closed

Fix for #480 and add one test case for that. #484

wants to merge 0 commits into from

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Dec 3, 2016

r? @fiveop, thank you.

@hicqu
Copy link
Contributor Author

hicqu commented Dec 3, 2016

why all checks have failed? It a big hit to me because it's the first time I make a pull request on github.
Please help me, thanks. :)

@fiveop
Copy link
Contributor

fiveop commented Dec 3, 2016

We don't need the pointer utilities. If you look at #445, you see that we solved the problem in the public interface by changing the parameter type of signal to T: Into<Optional<Signal>>, so that callers can specify None, if they don't want to provide a signal (or in this case no event).

I suggest (again), that you look at the changes made in #445 and base your PR on that.

Thank you for the PR.

@hicqu
Copy link
Contributor Author

hicqu commented Dec 7, 2016

Ok, I got that. I will use Option<&mut SockAddr> instead of pointer magic. New pull request will be later.

@hicqu hicqu closed this Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants