-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile on all travis platforms #553
Conversation
hrm not sure why CI didn't run on this.... I am going to trust that the constants are correct, and hopefully some day we'll actually tackle #341. Could you add something to the changelog for this, then I'll merge it. Thanks! |
I usually enable testing on all branches and then disable before finalizing the PR. I've re-enabled testing on all branches in What additions to the changelog were you thinking of? I'm making only the minimum number of changes to get things compiling. Switching over wholesale to |
Expanded the scope of the PR a bit to include additional changes I had lined up for #535
@kamalmarhubi I'm happy to put some notes in the changelog here, or would you rather wait until #536 is ready to go? |
@kamalmarhubi Not sure if you still wanted some notes in the changelog for this or if you wanted to wait until #536 is ready. |
@berkowski This does look pretty good to me, especially since it fixed the powerpc stuff that we've already had other people attempt. Two things:
So we'll defer on fixing the tests to #536. |
I'll try to get to those changes this weekend. |
Weekend comes early-ish. Updated changelog, reverted |
Does the signaled test work? You changed the declaration to all-caps, but not the usages. But since |
Ugh.. getting sloppy. Sorry. Removed |
Thanks, @berkowski! Now let's see how this shakes out on Travis and we can move on to #536. |
Addresses #534
One test failing:
This failure is consistent. I suspect it may stem from the
nix
implementation offd_set
, but nothing immediate jumps out as a cause.