Add pthread_self #591

king6cong · 2017-04-18T12:05:38Z

No description provided.

Susurrus · 2017-04-18T13:51:43Z

However I don't believe this is the right approach to this. If we can't support gettid directly on Mac, I don't believe we should emulate it for the sole reason of abstracting away platform differences. Nix only attempts to be a very small shim layer over unsafe libc interfaces. Any higher-level abstractions like this should be left to downstream crates. So instead of doing this, can you implement pthread_self() for all suitable platforms. Since that works on Linux and Mac someone could use that instead for cross-platform support.

king6cong · 2017-04-18T17:32:13Z

So instead of doing this, can you implement pthread_self() for all suitable platforms. Since that works on Linux and Mac someone could use that instead for cross-platform support.

To confirm , you mean that we should keep pthread_self out of nix or take it in in another form? 😃

Susurrus · 2017-04-18T18:49:34Z

I think we should provide a safe wrapper about pthread_self instead of pretending that pthread_self is gettid on Mac. It should be also noted that according to the man page:

The thread ID returned by pthread_self() is not the same thing as the kernel thread ID returned by a call to gettid(2)

Right now there's a bunch of pthread stuff is in src/sys/signal, but I'm not sure if this should be put there. I think putting it in a new src/sys/pthread.rs file is the correct way to do this. There's also previous conversation about this here.

king6cong · 2017-04-19T03:28:18Z

@Susurrus updated

Susurrus · 2017-04-19T03:35:23Z

That looks like a step in the right direction, but tests are failing.

Susurrus · 2017-04-20T05:35:08Z

@king6cong Can you also add an entry to the CHANGELOG for this?

king6cong · 2017-04-20T06:28:34Z

@Susurrus Yeah, haven't found the reason that tests fails, maybe tweak around ci setup to show failure details first.

Susurrus · 2017-04-20T17:05:47Z

Do the tests pass locally for you? If you have access to a mac and can test on one too, that might point us in the right direction.

king6cong · 2017-04-21T08:23:18Z

@Susurrus Yeah, it occurred to me that I could use my x86 mac to test i686 failure. Updated, Thanks!

Susurrus

A few minor issues, mostly the unix thing needs to get sorted out.

Susurrus · 2017-04-21T15:42:34Z

CHANGELOG.md

@@ -6,6 +6,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 ## [Unreleased]

 ### Added
+- Added `nix::sys::pthread::test_pthread_self`


This should show nix::sys::pthread::pthread_self instead.

Susurrus · 2017-04-21T15:48:14Z

src/sys/mod.rs

@@ -84,3 +84,6 @@ pub mod statfs;
              target_arch = "arm")),
          )]
 pub mod statvfs;
+
+#[cfg(unix)]


Aren't all the platforms covered by nix unix? This seems unnecessary.

Susurrus · 2017-04-21T15:48:37Z

test/sys/mod.rs

@@ -12,3 +12,5 @@ mod test_uio;

 #[cfg(target_os = "linux")]
 mod test_epoll;
+#[cfg(unix)]


Again, aren't all nix-supported platforms unix?

Susurrus · 2017-04-21T15:48:50Z

test/sys/test_pthread.rs

@@ -0,0 +1,6 @@
+use nix::sys::pthread::*;


Please add an empty line below this one.

Susurrus · 2017-04-21T15:48:57Z

src/sys/pthread.rs

@@ -0,0 +1,12 @@
+use libc::{self, pthread_t};
+
+


Delete one of these blank lines.

Susurrus · 2017-04-21T15:51:24Z

@king6cong I can't tell because the old code is gone, but what was the cause of the failures and what did you change to fix them?

king6cong · 2017-04-21T16:28:51Z

@Susurrus Updated. libc::pthread_self() should return pthread_t instead of pid_t, that's the reason that tests on several platforms failed

Susurrus · 2017-04-21T16:38:33Z

Great, thanks for clearing that up. Makes sense why it fixed things.

I wanted to ask, do you have a specific use case for this that this addition is all that's required for it to work? I'm going to block this on #590, so we can be sure that all platforms are passing before adding this, so we have a little time here in case there was any missing functionality you also needed. and wanted to add from pthread.h.

Susurrus · 2017-06-03T19:11:38Z

Can you make a new type Pthread, export it from nix, and also use that as the return value for pthread_self? I'd like nix to have all of its datatypes self-contained for better ergonomics for users.

king6cong · 2017-06-04T07:25:31Z

Updated

Susurrus · 2017-06-04T21:58:22Z

This looks good. We're going to wait until the new FreeBSD buildbot is integrated (#618) and this will be our first test.

asomers · 2017-06-05T03:29:26Z

Slight change of plans. We're no longer waiting for #618 .
bors r+

591: Add pthread_self r=asomers

bors · 2017-06-05T03:51:38Z

Build succeeded

continuous-integration/travis-ci/push

Susurrus · 2017-06-05T03:52:40Z

@King6Kong Thanks for your contribution!

king6cong force-pushed the master branch from 7d71db8 to 5841e4c Compare April 18, 2017 12:14

king6cong force-pushed the master branch from 5841e4c to 0a8373a Compare April 19, 2017 03:27

king6cong force-pushed the master branch from 0a8373a to 10fd1fb Compare April 21, 2017 07:18

king6cong force-pushed the master branch from 10fd1fb to af48b1e Compare April 21, 2017 12:24

Susurrus reviewed Apr 21, 2017

View reviewed changes

king6cong force-pushed the master branch from af48b1e to 509e9c4 Compare April 21, 2017 16:26

Susurrus changed the title ~~support gettid on macos~~ Add pthread_self Apr 21, 2017

Add pthread_self

445c247

king6cong force-pushed the master branch from 509e9c4 to 445c247 Compare June 4, 2017 07:24

Susurrus mentioned this pull request Jun 4, 2017

Continuous testing for FreeBSD #603

Closed

bors bot added a commit that referenced this pull request Jun 5, 2017

Merge #591

3be3e70

591: Add pthread_self r=asomers

bors bot merged commit 445c247 into nix-rust:master Jun 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pthread_self #591

Add pthread_self #591

king6cong commented Apr 18, 2017

Susurrus commented Apr 18, 2017

king6cong commented Apr 18, 2017

Susurrus commented Apr 18, 2017

king6cong commented Apr 19, 2017

Susurrus commented Apr 19, 2017

Susurrus commented Apr 20, 2017

king6cong commented Apr 20, 2017

Susurrus commented Apr 20, 2017

king6cong commented Apr 21, 2017

Susurrus left a comment

Susurrus Apr 21, 2017

Susurrus Apr 21, 2017

Susurrus Apr 21, 2017

Susurrus Apr 21, 2017

Susurrus Apr 21, 2017

Susurrus commented Apr 21, 2017

king6cong commented Apr 21, 2017 •

edited

Loading

Susurrus commented Apr 21, 2017

Susurrus commented Jun 3, 2017

king6cong commented Jun 4, 2017

Susurrus commented Jun 4, 2017

asomers commented Jun 5, 2017

bors bot commented Jun 5, 2017

Susurrus commented Jun 5, 2017

Add pthread_self #591

Add pthread_self #591

Conversation

king6cong commented Apr 18, 2017

Susurrus commented Apr 18, 2017

king6cong commented Apr 18, 2017

Susurrus commented Apr 18, 2017

king6cong commented Apr 19, 2017

Susurrus commented Apr 19, 2017

Susurrus commented Apr 20, 2017

king6cong commented Apr 20, 2017

Susurrus commented Apr 20, 2017

king6cong commented Apr 21, 2017

Susurrus left a comment

Choose a reason for hiding this comment

Susurrus Apr 21, 2017

Choose a reason for hiding this comment

Susurrus Apr 21, 2017

Choose a reason for hiding this comment

Susurrus Apr 21, 2017

Choose a reason for hiding this comment

Susurrus Apr 21, 2017

Choose a reason for hiding this comment

Susurrus Apr 21, 2017

Choose a reason for hiding this comment

Susurrus commented Apr 21, 2017

king6cong commented Apr 21, 2017 • edited Loading

Susurrus commented Apr 21, 2017

Susurrus commented Jun 3, 2017

king6cong commented Jun 4, 2017

Susurrus commented Jun 4, 2017

asomers commented Jun 5, 2017

bors bot commented Jun 5, 2017

Build succeeded

Susurrus commented Jun 5, 2017

king6cong commented Apr 21, 2017 •

edited

Loading