Skip to content

Remove workaround for pub extern crate #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2017
Merged

Remove workaround for pub extern crate #694

merged 1 commit into from
Jul 25, 2017

Conversation

jonas-schievink
Copy link
Contributor

@jonas-schievink jonas-schievink commented Jul 20, 2017 •
edited
Loading

On semi-recent Rust versions (I think 1.8+) this now works properly.

Closes #655

@jonas-schievink
Remove workaround for pub extern crate
39f3372 
On semi-recent Rust versions (I think 1.8+) this now works properly.
@Susurrus
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Jul 25, 2017
@bors
Merge #694
23a9882 
694: Remove workaround for `pub extern crate` r=Susurrus

On semi-recent Rust versions (I think 1.8+) this now works properly.

Closes #655
@bors
Copy link
Contributor

bors bot commented Jul 25, 2017

Build failed

@asomers
Copy link
Member

asomers commented Jul 25, 2017

This looks like a temporary failure in rustup. We can try remerging.

bors r+ susurrus

bors bot added a commit that referenced this pull request Jul 25, 2017
@bors
Merge #694
3f80902 
694: Remove workaround for `pub extern crate` r=asomers

On semi-recent Rust versions (I think 1.8+) this now works properly.

Closes #655
@bors
Copy link
Contributor

bors bot commented Jul 25, 2017

Build succeeded

@bors bors bot merged commit 39f3372 into nix-rust:master Jul 25, 2017
@LukeMathWalker LukeMathWalker mentioned this pull request Sep 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonas-schievink @Susurrus @asomers