Fix multiple issues with POSIX AIO #715
Conversation
CHANGELOG.md
Outdated
| - `AioCb::Drop` will now panic if the `AioCb` is still in-progress ([#715](https://github.com/nix-rust/nix/pull/715)) | ||
|
|
||
| ### Fixed | ||
| - Fixed error handling in `AioCb::fsync`, `AioCb::read`, and `AioCb::write` ([#715](https://github.com/nix-rust/nix/pull/715)) |
There was a problem hiding this comment.
I think adding the specific thing that was fixed here would be good rather than having people see this and then having to reference the PR.
|
@asomers That's a more clear CHANGELOG entry, thanks. But I must ask why are these tests only ran on FreeBSD? |
|
But there are still errors on Mac and a musl target that will need to be fixed. |
|
It seems that on Linux, |
asomers
force-pushed
the
issue_714
branch
2 times, most recently
from
c051cb9 to
1bff1ac
Compare
|
Somehow I seriously screwed up the squash. I'll try to fix it. |
Printing a warning message to stderr isn't really appropriate, because there's no way to guarantee that stderr is even valid. Nor is aio_suspend necessarily an appropriate action to take.
Previously, the `AioCb`'s `in_progress` field would erroneously be set to `true`, even if the syscall had an error Fixes nix-rust#714
|
bors r+ chrisvest |
715: Fix multiple issues with POSIX AIO r=asomers a=asomers
Fixed error handling in `AioCb::fsync`, `AioCb::read`, and `AioCb::write`
Previously, the `AioCb`'s `in_progress` field would erroneously be set
to `true`, even if the syscall had an error
Fixes #714
AioCb::Drop will now panic for in-progress AioCb
Printing a warning message to stderr isn't really appropriate, because
there's no way to guarantee that stderr is even valid. Nor is
aio_suspend necessarily an appropriate action to take.
|
It looks like bors is ignoring me because chrisvest doesn't have the authority to approve a merge? I thought that everyhhing following "bors r+" was ignored, but I guess not. bors r+ |
|
Not awaiting review |
|
It wasn't ignoring you. It was just being slow. |
Fixed error handling in
AioCb::fsync,AioCb::read, andAioCb::writeAioCb::Drop will now panic for in-progress AioCb