haiku: add platform support. #772
Conversation
There was a problem hiding this comment.
Moving constants into libc is important. I haven't finished reviewing this PR yet, but I'll try to get to it tonight. Stylistically, I have concerns about the use of #[cfg(...)] vs #[cfg(not(...))]. We should consistently use either the positive form or the negative form in each block of code, and not mix them.
| @@ -1910,6 +1925,172 @@ mod consts { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(target_os = "haiku")] | |||
There was a problem hiding this comment.
Nix does not define constants anymore. Instead, all of these should be defined in the libc crate, and nix should reference libc.
There was a problem hiding this comment.
You mean how the linux version is done? I had wondered why it was different to the other platforms.
There was a problem hiding this comment.
Yeah. It looks like Somebody fixed the Linux definitions in change 3354ffe , but not other OS's.
| @@ -47,6 +47,12 @@ unsafe fn errno_location() -> *mut c_int { | |||
| __errno() | |||
| } | |||
|
|
|||
| #[cfg(target_os = "haiku")] | |||
| unsafe fn errno_location() -> *mut c_int { | |||
| extern { fn _errnop() -> *mut c_int; } | |||
There was a problem hiding this comment.
This should also be declared in libc instead of here.
|
Restricting to just the 'positive' would create unnecessarily complex |
| @@ -28,6 +28,7 @@ libc_bitflags!( | |||
| O_ALT_IO; | |||
| /// Open the file in append-only mode. | |||
| O_APPEND; | |||
| #[cfg(not(target_os = "haiku"))] | |||
There was a problem hiding this comment.
These should actually go underneath the comment.
| @@ -92,7 +92,7 @@ mod os { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(any(target_os = "macos", target_os = "freebsd", target_os = "dragonfly", target_os = "ios", target_os = "openbsd", target_os = "netbsd"))] | |||
| #[cfg(any(target_os = "macos", target_os = "freebsd", target_os = "dragonfly", target_os = "ios", target_os = "openbsd", target_os = "netbsd", target_os = "haiku"))] | |||
|
@jessicah You have any time to get around to resolving this? We'd love to have Haiku support! |
|
@jessicah Wanted to ping you again on this. |
|
Sorry, yes, I will get back to it; laptop died, and haven't gotten around to setting up on my other machine. |
|
We're about to cut a new release soon and I'd love to say that we fixed up Haiku support. So whenever you have time I'd love to merge this. BTW what's your involvement with Haiku? You run it as a daily driver or just want to play with Rust on Haiku? |
|
Okay, I'll see if I can get to it this week. I'm core committer/maintainer. Mainly working on rust so can run librespot on Haiku :p |
|
I'm going to go ahead and close this, @jessicah, as it's been over 2 months since your last update. Please either reopen this PR or submit a new one that's been rebased on HEAD as a lot has changed since this was opened. |
No description provided.