Add step function to ptrace #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added step function to ptrace, this follows the same form as the PTRACE_CONTINUE by advanced the tracee by a single step!
|
Once this has been approved I'll update the changelog with the PR number etc 😄 |
|
I'd love to get an example and a test in here. Specifically it'd be good to show the syntax for how the optional argument is called both with and without it. |
|
Will do, am I right in recalling there's an issue with using waitpid and signals in tests? |
Added doc test for sys::ptrace::step and also updated the changelog.
Susurrus
suggested changes
Feb 1, 2018
src/sys/ptrace.rs
Outdated
| /// `ptrace(PTRACE_SINGLESTEP, ...)` | ||
| /// | ||
| /// Advances the execution of the process with PID `pid` by a single step optionally delivering a | ||
| /// single specified by `sig`. |
Susurrus
reviewed
Feb 3, 2018
src/sys/ptrace.rs
Outdated
| /// fn main() { | ||
| /// let dummy_pid = Pid::from_raw(0); | ||
| /// | ||
| /// let _ = step(dummy_pid, Some(Signal::SIGSTOP)); |
There was a problem hiding this comment.
Shouldn't you not need that Some() on this line?
Also, any way to make this a more realistic example? This looks more like a basic test than any realistic code that might help a user use this function.
Example now matches something more akin to an actual usecase.
|
Hi @Susurrus I've made the changes, just checking to see if this is ready to be merged yet? |
Susurrus
approved these changes
Feb 7, 2018
|
LGTM, thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 7, 2018
852: Add step function to ptrace r=Susurrus a=xd009642 Added step function to ptrace, this follows the same form as the PTRACE_CONTINUE by advanced the tracee by a single step! Found when I was updating to nix 0.10.0 that this function had been missed out. Minor addition as `SINGLESTEP` works the same as `CONTINUE`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added step function to ptrace, this follows the same form as the PTRACE_CONTINUE by advanced the tracee by a single step!
Found when I was updating to nix 0.10.0 that this function had been missed out. Minor addition as
SINGLESTEPworks the same asCONTINUE