Update InterfaceFlags
#853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like Android is failing. Are these flags available on Android? If so, they should be added to |
|
i will check android later. |
|
Needs an entry in the CHANGELOG. Otherwise, LGTM. |
Susurrus
suggested changes
Feb 4, 2018
src/net/if_.rs
Outdated
| @@ -215,6 +215,15 @@ libc_bitflags!( | |||
| /// Don't exchange routing info. | |||
| #[cfg(any(target_os = "solaris"))] | |||
| IFF_NORTEXCH; | |||
| /// Do not provide packet information | |||
| #[cfg(any(target_os = "linux"))] | |||
src/net/if_.rs
Outdated
| #[cfg(any(target_os = "linux"))] | ||
| IFF_NO_PI as i32; | ||
| /// TUN device (no Ethernet headers) | ||
| #[cfg(any(target_os = "linux"))] |
src/net/if_.rs
Outdated
| #[cfg(any(target_os = "linux"))] | ||
| IFF_TUN as i32; | ||
| /// TAP device | ||
| #[cfg(any(target_os = "linux"))] |
src/net/if_.rs
Outdated
| @@ -215,6 +215,15 @@ libc_bitflags!( | |||
| /// Don't exchange routing info. | |||
| #[cfg(any(target_os = "solaris"))] | |||
| IFF_NORTEXCH; | |||
| /// Do not provide packet information | |||
| #[cfg(any(target_os = "linux"))] | |||
| IFF_NO_PI as i32; | |||
There was a problem hiding this comment.
This should be c_int for all 3 of these to match the enum declaration.
LuoZijun
force-pushed
the
patch-1
branch
2 times, most recently
from
2075aa7 to
147f63a
Compare
|
upstream PR: rust-lang/libc#916 |
LuoZijun
force-pushed
the
patch-1
branch
3 times, most recently
from
21d30e2 to
b7868e5
Compare
|
@Susurrus ping ... |
|
Please add a link to the PR in the CHANGELOG like the other entries do. |
|
Updated. |
Susurrus
approved these changes
Feb 7, 2018
Susurrus
suggested changes
Feb 7, 2018
CHANGELOG.md
Outdated
| @@ -10,6 +10,8 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
| ### Changed | |||
| - Display and Debug for SysControlAddr now includes all fields. | |||
| ([#837](https://github.com/nix-rust/nix/pull/837)) | |||
| - `nix::net::if_::InterfaceFlags` now support `IFF_NO_PI/IFF_TUN/IFF_TAP` flags on linux-like system. | |||
There was a problem hiding this comment.
This is technically an addition since the interface didn't change, but new functionally was added. Please move it to the Added section.
Also change "system" to "systems"
LuoZijun
force-pushed
the
patch-1
branch
2 times, most recently
from
69d0f76 to
42deadf
Compare
Add Flags: `IFF_NO_PI`, `IFF_TUN`, `IFF_TAP`.
Susurrus
approved these changes
Feb 8, 2018
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Flags:
IFF_NO_PI,IFF_TUN,IFF_TAP.