WIP Replace AioCb::from_bytes with more generic from_boxed_slice #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
commented
Mar 5, 2018
Cargo.toml
Outdated
| [target.'cfg(target_os = "dragonfly")'.build-dependencies] | ||
| gcc = "0.3" | ||
|
|
||
| [dev-dependencies] | ||
| bytes = { version="0.5.0", default_features = false } |
There was a problem hiding this comment.
The bytes crate is now only used for examples and tests. I could've removed it entirely, but since we explicitly supported it in version 0.10.0, I think we ought to use it in the examples as a kind of migration guide.
Supporting the bytes crate was unnecessarily specific. This change replaces from_bytes and from_bytes_mut with from_boxed_slice and from_boxed_mut_slice, which can work with anything that implements Borrow<[u8]> and BorrowMut<[u8]>, respectively.
|
Looks like using Cargo's patch feature only works some of the time. Builds are randomly passing or failing based on whether Cargo can download |
|
This is not quite right; I'm working on a fix. |
asomers
changed the title
|
I'm combining this with PR #872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting the bytes crate was unnecessarily specific. This change
replaces from_bytes and from_bytes_mut with from_boxed_slice and
from_boxed_mut_slice, which can work with anything that implements
Borrow<[u8]> and BorrowMut<[u8]>, respectively.