socket: add AF_UNSPEC to AddressFamily #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, this looks fine. Just add an entry to CHANGELOG and I'll merge it. |
Signed-off-by: Levente Kurusa <lkurusa@acm.org>
|
@asomers great! I've added an entry to the CHANGELOG. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 15, 2018
948: socket: add AF_UNSPEC to AddressFamily r=asomers a=levex Hi! I work on a [crate](https://github.com/levex/network-bridge-rs) where it would make sense to use `AF_UNSPEC` in place of `AF_INET`, since that's the API most bridge libraries use. Unfortunately, it seems that `nix` is missing a representation for `AF_UNSPEC`. This PR adds `Unspec` to `AddressFamily`, so we can now represent `AF_UNSPEC`. Co-authored-by: Levente Kurusa <lkurusa@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I work on a crate where it would make sense to use
AF_UNSPECin place ofAF_INET, since that's the API most bridge libraries use. Unfortunately, it seems thatnixis missing a representation forAF_UNSPEC. This PR addsUnspectoAddressFamily, so we can now representAF_UNSPEC.