Add wrapper for acct(2) #952

jabedude · 2018-10-12T01:38:53Z

This PR aims to add a nix wrapper for acct(2).

asomers

Don't forget to add a CHANGELOG entry.

Also, might I ask what you have in mind for this function? How are you planning to parse the accounting file? Are you writing a separate crate for that, or just planning to use lastcomm(1), or will you be adding that functionality to Nix?

asomers · 2018-10-12T15:05:46Z

src/unistd.rs

+///
+/// See also [acct(2)](https://linux.die.net/man/2/acct)
+#[cfg(any(target_os = "linux", target_os = "android"))]
+pub fn acct(filename: &CString) -> Result<Void> {


The result type is wrong. Result<Void> indicates that the function will always fail. Perhaps you mean Result<()>?

Also, the argument type is wrong. This API doesn't provide anyway to disable process accounting once it's enabled. I suggest creating an acct module, and giving it two functions enable(filename: &CString), and disable().

Wonderful ideas. I will definitely work on those changes.

asomers · 2018-10-12T15:12:58Z

src/unistd.rs

+/// Switch process accounting on or off
+///
+/// See also [acct(2)](https://linux.die.net/man/2/acct)
+#[cfg(any(target_os = "linux", target_os = "android"))]


acct is available on many more operating systems than this. Please enable it everywhere that it's supported. You may need to submit a separate PR to libc if there are some declarations missing.

asomers · 2018-10-12T15:15:30Z

src/unistd.rs

+        libc::acct(filename.as_ptr())
+    };
+
+    Err(Error::Sys(Errno::last()))


This is the wrong way to set the return code. For one thing, it will always indicate an error. For another, errno won't be set if acct passes. See fchmod in sys/stat.rs for an example of how to do it right.

test/test_unistd.rs

asomers · 2018-10-12T15:22:19Z

src/unistd.rs

+///
+/// See also [acct(2)](https://linux.die.net/man/2/acct)
+#[cfg(any(target_os = "linux", target_os = "android"))]
+pub fn acct(filename: &CString) -> Result<Void> {


Also, the argument type is wrong. In Rust you should rarely use a &CString reference explicitly. Better to use the borrowed form &CStr. And in Nix, you should generally use NixPath instead. See mknod in sys/stat.rs for an example.

jabedude · 2018-10-13T01:29:28Z

I am currently planning on using lastcomm, but I might make a separate crate for parsing pacct files.

jabedude · 2018-10-15T19:47:06Z

I added acct(2) to the BSD tree of libc See here.. CI should pass now

asomers · 2018-10-15T20:25:27Z

src/unistd.rs

@@ -1439,6 +1439,32 @@ pub fn sleep(seconds: c_uint) -> c_uint {
    unsafe { libc::sleep(seconds) }
 }

+#[cfg(target_family = "unix")]


The target_family should be unnecessary. Nix only runs on unix operating systems.

test/test_unistd.rs

asomers

You'll need to rebase, not just merge, the master branch. Merging the master branch into your PR makes the history screwy.

test/test_unistd.rs

asomers · 2018-10-20T23:56:58Z

CHANGELOG.md

@@ -25,6 +25,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
  ([#956](https://github.com/nix-rust/nix/pull/956))
 - Added a `fchownat` wrapper.
  ([#955](https://github.com/nix-rust/nix/pull/955))
+- Added a `acct` wrapper module for enabling and disabling process accounting ([#952](https://github.com/nix-rust/nix/pull/952))


Wrap to 80 columns, please.

test/test_unistd.rs

asomers · 2018-10-21T03:25:22Z

Hm, I tried using Github's online editor to reword a comment, but it seems that doing so creates a separate commit. Can you please squash those commits for me? I can't do it with the merge button, because Nix uses bors to merge.

This patch adds a wrapper for the acct(2) syscall, with two functions for enabling and disabling process accounting.

jabedude · 2018-10-21T19:50:15Z

Done!

asomers

Thanks for your contribution!

bors r+

952: Add wrapper for acct(2) r=asomers a=jabedude This PR aims to add a nix wrapper for acct(2). Co-authored-by: Josh Abraham <sinisterpatrician@gmail.com>

bors · 2018-10-24T20:30:42Z

Build succeeded

asomers requested changes Oct 12, 2018

View reviewed changes

jabedude force-pushed the acct-api branch from 01e6a00 to 2ef9333 Compare October 13, 2018 01:28

asomers requested changes Oct 15, 2018

View reviewed changes

jabedude force-pushed the acct-api branch 2 times, most recently from 632a600 to e030707 Compare October 15, 2018 21:55

asomers requested changes Oct 19, 2018

View reviewed changes

test/test_unistd.rs Show resolved Hide resolved

asomers requested changes Oct 20, 2018

View reviewed changes

jabedude force-pushed the acct-api branch 2 times, most recently from 837d87c to 84811a9 Compare October 21, 2018 00:45

jabedude force-pushed the acct-api branch 2 times, most recently from c773ea4 to 3d56c27 Compare October 21, 2018 19:37

Add acct(2) wrapper API

0ce57d9

This patch adds a wrapper for the acct(2) syscall, with two functions for enabling and disabling process accounting.

jabedude force-pushed the acct-api branch from 3d56c27 to 0ce57d9 Compare October 21, 2018 19:49

asomers approved these changes Oct 24, 2018

View reviewed changes

bors bot added a commit that referenced this pull request Oct 24, 2018

Merge #952

19affae

952: Add wrapper for acct(2) r=asomers a=jabedude This PR aims to add a nix wrapper for acct(2). Co-authored-by: Josh Abraham <sinisterpatrician@gmail.com>

bors bot merged commit 0ce57d9 into nix-rust:master Oct 24, 2018

jabedude deleted the acct-api branch October 24, 2018 22:48

asomers added a commit to asomers/nix that referenced this pull request Nov 21, 2018

Fix unused warnings on FreeBSD from PR nix-rust#952

7d9a679

asomers added a commit to asomers/nix that referenced this pull request Nov 22, 2018

Fix unused warnings on FreeBSD from PR nix-rust#952

92e5c01

asomers added a commit to asomers/nix that referenced this pull request Nov 23, 2018

Fix unused warnings on FreeBSD from PR nix-rust#952

f7be5da

levex pushed a commit to levex/nix that referenced this pull request Dec 3, 2018

Fix unused warnings on FreeBSD from PR nix-rust#952

e00a621

SteveLauC mentioned this pull request Nov 29, 2023

FreeBSD's rfork wrapper proposal #2121

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add wrapper for acct(2) #952

Add wrapper for acct(2) #952

jabedude commented Oct 12, 2018

asomers left a comment

asomers Oct 12, 2018

asomers Oct 12, 2018

jabedude Oct 12, 2018

asomers Oct 12, 2018

asomers Oct 12, 2018

asomers Oct 12, 2018

jabedude commented Oct 13, 2018

jabedude commented Oct 15, 2018

asomers Oct 15, 2018

asomers left a comment

asomers Oct 20, 2018

asomers commented Oct 21, 2018

jabedude commented Oct 21, 2018

asomers left a comment

bors bot commented Oct 24, 2018

Add wrapper for acct(2) #952

Add wrapper for acct(2) #952

Conversation

jabedude commented Oct 12, 2018

asomers left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jabedude commented Oct 13, 2018

jabedude commented Oct 15, 2018

Choose a reason for hiding this comment

asomers left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asomers commented Oct 21, 2018

jabedude commented Oct 21, 2018

asomers left a comment

Choose a reason for hiding this comment

bors bot commented Oct 24, 2018

Build succeeded