Added AddressType type to ptrace::linux + peek/poke user fix #958
Conversation
xd009642
changed the title
|
I also realised I accidentally conflated |
|
@asomers do you have time to have a look at this? |
|
So the |
|
Yeah there's no tests for it so I didn't realise I'd made a mistake. Unfortunately it's pretty hard to test as it relies on knowledge of the user struct and what's happening in the test executable - unless you can think of a better way? |
|
No. I'm not even clear on what |
|
I think it might be, |
This was added to the BSD ptrace API and probably should have been added to tyhe linux API to make it easier to write code for both platforms without the user having to reexport the types to their own crate.
CHANGELOG.md
Outdated
| @@ -30,6 +30,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
| ([#949](https://github.com/nix-rust/nix/pull/949)) | |||
| - Added a `acct` wrapper module for enabling and disabling process accounting | |||
| ([#952](https://github.com/nix-rust/nix/pull/952)) | |||
| ([#949](https://github.com/nix-rust/nix/pull/949)) ([#958](https://github.com/nix-rust/nix/pull/958)) | |||
There was a problem hiding this comment.
Looks like you got a merge error when you rebased.
CHANGELOG.md
Outdated
| - Added a `acct` wrapper module for enabling and disabling process accounting | ||
| ([#952](https://github.com/nix-rust/nix/pull/952)) | ||
| ([#949](https://github.com/nix-rust/nix/pull/949)) |
|
Fixed (I hope) |
958: Added AddressType type to ptrace::linux + peek/poke user fix r=asomers a=xd009642 This was added to the BSD ptrace API and probably should have been added to the linux API to make it easier to write code for both platforms without the user having to reexport the types to their own crate. I went to use the latest nix myself and found that having this added would improve usability for nix users. Could potentially add a type for what they return (BSDs: `c_int`, linux: `c_long`). Data input might be trickier as linux is `*mut c_void` and BSD just takes data as `c_int`. Co-authored-by: xd009642 <danielmckenna93@gmail.com>
This was added to the BSD ptrace API and probably should have been added to the linux API to make it easier to write code for both platforms without the user having to reexport the types to their own crate.
I went to use the latest nix myself and found that having this added would improve usability for nix users.
Could potentially add a type for what they return (BSDs:
c_int, linux:c_long). Data input might be trickier as linux is*mut c_voidand BSD just takes data asc_int.