Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jazz_hands for non-rails projects #13

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

jrhe
Copy link

@jrhe jrhe commented Aug 9, 2013

This gets jazz_hands working for non-rails projects. Gems are automatically required on requiring jazz_hands.

@wyaeld
Copy link

wyaeld commented Oct 21, 2013

looks like a very useful feature to have

@jrhe
Copy link
Author

jrhe commented Feb 10, 2014

@nixme Any thought on this?

@DAddYE
Copy link

DAddYE commented Jun 4, 2014

Indeed, why cannot be merged?

@yn
Copy link

yn commented Jul 28, 2014

+1 for at least a reply from @nixme about this pull request.

@nixme
Copy link
Owner

nixme commented Jul 28, 2014

Sorry, taking a look now. I do want this functionality in master

require 'jazz_hands/hirb_ext'
require 'pry-debugger'
require 'active_support/core_ext/module/attribute_accessors'
require 'active_support/core_ext/kernel/reporting'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not every non-Rails project uses active_support can we get rid of that?

@yn
Copy link

yn commented Nov 26, 2014

@nixme is the response from the original merge requester necessary to get this into master?

@nixme
Copy link
Owner

nixme commented Nov 26, 2014

Probably although I can use this as a blueprint. Sorry been behind on my projects. I have time this Thanksgiving holiday to look at everything and merge.

@yn
Copy link

yn commented Nov 28, 2014

@nixme happy to help if you'd like another pair of eyes.

@jrhe
Copy link
Author

jrhe commented Nov 29, 2014

Can’t really remember what the reporting active support dependency was for but the attribute accessors one is just for module accessors.

Perhaps an easy way to remove the dependency would to be just to copy the files wholesale into a utils directory and change the namespace. This way the functionality doesn’t need adding into the code and the existing abstractions stay.

On 28 Nov 2014, at 00:51, yn notifications@github.com wrote:

@nixme https://github.com/nixme happy to help if you'd like another pair of eyes.


Reply to this email directly or view it on GitHub #13 (comment).

@jrhe
Copy link
Author

jrhe commented Dec 21, 2014

Also not every project uses active support but does it harm adding it as a development dependency for use with pry?

@jrhe
Copy link
Author

jrhe commented Dec 22, 2014

Managed to mess up this branch. Having trouble getting jazz_hands working on my new machine.

@nixme Could you consider merging in the 'bring-your-own-debugger' branch OR switching to conditional dependencies based on the ruby version.

Shouldn't be too hard to extract out the dependencies.

@MichaelSp
Copy link

anything new here?

@plribeiro3000
Copy link

@MichaelSp take a look at my fork: jazz_fingers.

This project is abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants