-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jazz_hands for non-rails projects #13
base: master
Are you sure you want to change the base?
Conversation
looks like a very useful feature to have |
@nixme Any thought on this? |
Indeed, why cannot be merged? |
+1 for at least a reply from @nixme about this pull request. |
Sorry, taking a look now. I do want this functionality in master |
require 'jazz_hands/hirb_ext' | ||
require 'pry-debugger' | ||
require 'active_support/core_ext/module/attribute_accessors' | ||
require 'active_support/core_ext/kernel/reporting' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not every non-Rails project uses active_support
can we get rid of that?
@nixme is the response from the original merge requester necessary to get this into master? |
Probably although I can use this as a blueprint. Sorry been behind on my projects. I have time this Thanksgiving holiday to look at everything and merge. |
@nixme happy to help if you'd like another pair of eyes. |
Can’t really remember what the reporting active support dependency was for but the attribute accessors one is just for module accessors. Perhaps an easy way to remove the dependency would to be just to copy the files wholesale into a utils directory and change the namespace. This way the functionality doesn’t need adding into the code and the existing abstractions stay.
|
Also not every project uses active support but does it harm adding it as a development dependency for use with pry? |
…ut_rails * 'without_rails' of github.com:jrhe/jazz_hands: Incremented version number to 0.6.0 Non-rails project support Conflicts: CHANGELOG.md
Managed to mess up this branch. Having trouble getting jazz_hands working on my new machine. @nixme Could you consider merging in the 'bring-your-own-debugger' branch OR switching to conditional dependencies based on the ruby version. Shouldn't be too hard to extract out the dependencies. |
anything new here? |
@MichaelSp take a look at my fork: This project is abandoned. |
This gets jazz_hands working for non-rails projects. Gems are automatically required on requiring jazz_hands.