-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NullAway integration tests #6
Conversation
@theron-wang I'd like to merge this PR, so that we can get reliable results on CI for the NullAway bugs. In particular, I want to make sure that as we make changes to fix one bug, we don't accidentally break another that we already thought was working. So, my plan is going to be to merge this PR as-is soon (unless you object), and then merge njit-jerse/specimin#342 as soon as I can get the status right so that it passes CI. |
@kelloggm Yep, sounds good. Let me just remove some debugging code before you merge. I also need to update the compilation scripts for na-97. |
@kelloggm Should be ready to merge. I'm not sure if my change in |
Thanks. The change looks fine to me, but the best way to tell will just be to merge all of this and then see whether CI succeeds. |
This PR adds the following NullAway integration tests to the evaluation script:
Most of these currently do not work as expected, so we should avoid forking these repos into the organization for now, just in case we need to modify
build.gradle
or other specimin files. Once we address the issues, we can work on the status json files insrc/main/resources
.