Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NullAway integration tests #6

Merged
merged 9 commits into from
Jul 29, 2024
Merged

Conversation

theron-wang
Copy link
Collaborator

@theron-wang theron-wang commented Jul 24, 2024

This PR adds the following NullAway integration tests to the evaluation script:

  • na-89
  • na-97 (pass)
  • na-102 (pass)
  • na-103 (pass)
  • na-176
  • na-323
  • na-347 (pass)
  • na-389 (pass)
  • na-705
  • na-791a (pass)
  • na-791b

Most of these currently do not work as expected, so we should avoid forking these repos into the organization for now, just in case we need to modify build.gradle or other specimin files. Once we address the issues, we can work on the status json files in src/main/resources.

@kelloggm
Copy link

@theron-wang I'd like to merge this PR, so that we can get reliable results on CI for the NullAway bugs. In particular, I want to make sure that as we make changes to fix one bug, we don't accidentally break another that we already thought was working.

So, my plan is going to be to merge this PR as-is soon (unless you object), and then merge njit-jerse/specimin#342 as soon as I can get the status right so that it passes CI.

@theron-wang
Copy link
Collaborator Author

theron-wang commented Jul 29, 2024

@kelloggm Yep, sounds good. Let me just remove some debugging code before you merge. I also need to update the compilation scripts for na-97.

@theron-wang
Copy link
Collaborator Author

@kelloggm Should be ready to merge. I'm not sure if my change in check_compilation.sh is valid, though, so if you could check that I would appreciate it. Thanks!

@kelloggm
Copy link

@kelloggm Should be ready to merge. I'm not sure if my change in check_compilation.sh is valid, though, so if you could check that I would appreciate it. Thanks!

Thanks. The change looks fine to me, but the best way to tell will just be to merge all of this and then see whether CI succeeds.

@kelloggm kelloggm merged commit 4fb8e17 into njit-jerse:main Jul 29, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants