Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing comments from input codes #29

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

LoiNguyenCS
Copy link
Collaborator

No description provided.

@LoiNguyenCS
Copy link
Collaborator Author

Professor, this is the PR to remove all the comments from the input codes.

There are some past test files that include comments, so I have run them through this new version of Specimin to have the new expected results for them.

I have also modified SpeciminTestExecutor to ignore blank lines and white spaces. As PrintWriter has a bit different in spacing compared to LexicalPreservingPrinter, I think ignoring blank lines and spacing is a better method compared to re-write the expected results for every test file.

@LoiNguyenCS LoiNguyenCS requested a review from kelloggm October 4, 2023 22:39
@LoiNguyenCS
Copy link
Collaborator Author

Professor, I have updated the code. Please take a look.

@LoiNguyenCS LoiNguyenCS requested a review from kelloggm October 5, 2023 19:31
@kelloggm kelloggm merged commit 04cc94e into njit-jerse:main Oct 6, 2023
@kelloggm kelloggm deleted the delete-comments branch October 6, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants