include java/
files in output if they are targeted
#344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In na-97, where we target a
java/
file, the targeted file (java/util/atomic/concurrent/Striped64.java
, I believe) was being excluded from the output because of these lines inSpeciminRunner
:The reason it worked on Windows was probably because Windows uses backslashes, and it didn't work on Unix because of the forward slash comparison here. I changed it so that the target file is preserved in the output no matter what, even if it starts with
java/
(orjava\
). This should make na-97 work on both OSes.I didn't include a test case for this, since NullAway bugs are now in the evaluation script, but if you'd like, I could add one. Thanks!