Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include java/ files in output if they are targeted #344

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

theron-wang
Copy link
Collaborator

In na-97, where we target a java/ file, the targeted file (java/util/atomic/concurrent/Striped64.java, I believe) was being excluded from the output because of these lines in SpeciminRunner:

if (target.getKey().startsWith("java/")) {
    continue;
}

The reason it worked on Windows was probably because Windows uses backslashes, and it didn't work on Unix because of the forward slash comparison here. I changed it so that the target file is preserved in the output no matter what, even if it starts with java/ (or java\). This should make na-97 work on both OSes.

I didn't include a test case for this, since NullAway bugs are now in the evaluation script, but if you'd like, I could add one. Thanks!

@kelloggm
Copy link
Collaborator

CI should fail on this change, since we expect it to fix na-97 but it doesn't change the preservation status file. That will be a good test of the updated CI.

@kelloggm kelloggm self-requested a review July 29, 2024 20:53
@theron-wang
Copy link
Collaborator Author

Whoops, I think I have to merge the latest changes first.

@kelloggm kelloggm merged commit 3d3a414 into njit-jerse:main Jul 29, 2024
2 checks passed
@theron-wang theron-wang deleted the include-target-java-file branch August 1, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants