Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize fields #58

Merged
merged 8 commits into from
Nov 28, 2023
Merged

Minimize fields #58

merged 8 commits into from
Nov 28, 2023

Conversation

LoiNguyenCS
Copy link
Collaborator

No description provided.

@LoiNguyenCS
Copy link
Collaborator Author

Professor,

This is the PR to minimize fields so that we don't have to include class files related to the initializers of those fields in the final output.

Please take a look. Thank you.

@LoiNguyenCS LoiNguyenCS requested a review from kelloggm November 28, 2023 05:59
@kelloggm
Copy link
Collaborator

@LoiNguyenCS this should fix #56, right? In general, it's always helpful to include a link to the issue that a PR is intended to solve in the issue description; for example, see this PR - notice how the first thing in my comment is a link to the associated issue

@LoiNguyenCS
Copy link
Collaborator Author

this should fix #56, right?

Sorry for the ambiguity. This PR should fix #41.

@LoiNguyenCS
Copy link
Collaborator Author

Professor,

I have updated the codes based on your comments. Please take a look.

@LoiNguyenCS LoiNguyenCS requested a review from kelloggm November 28, 2023 17:02
Copy link
Collaborator

@kelloggm kelloggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After my two minor comments are addressed, you can merge without another review from me. Please also close issue #41 when you do.

@LoiNguyenCS LoiNguyenCS merged commit 2bb200e into njit-jerse:main Nov 28, 2023
1 check passed
@LoiNguyenCS LoiNguyenCS deleted the minimize-fields branch November 28, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants