-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimize fields #58
Minimize fields #58
Conversation
Professor, This is the PR to minimize fields so that we don't have to include class files related to the initializers of those fields in the final output. Please take a look. Thank you. |
@LoiNguyenCS this should fix #56, right? In general, it's always helpful to include a link to the issue that a PR is intended to solve in the issue description; for example, see this PR - notice how the first thing in my comment is a link to the associated issue |
src/main/java/org/checkerframework/specimin/TargetMethodFinderVisitor.java
Show resolved
Hide resolved
src/main/java/org/checkerframework/specimin/MethodPrunerVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/checkerframework/specimin/MethodPrunerVisitor.java
Outdated
Show resolved
Hide resolved
Professor, I have updated the codes based on your comments. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. After my two minor comments are addressed, you can merge without another review from me. Please also close issue #41 when you do.
No description provided.