Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #74 - Implements primary keys as a specific type #131

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

chaseWillden
Copy link
Collaborator

Implements the code recommended from here: #74.

Implements std::str::FromStr for PrimaryKey
Implements std::fmt::Display for PrimaryKey

Copy link

vercel bot commented Sep 28, 2024

@chaseWillden is attempting to deploy a commit to the Marcus Cvjeticanin Team on Vercel.

A member of the Team first needs to authorize it.

@chaseWillden
Copy link
Collaborator Author

@mjovanc, as a side, if you recreate your neo.db table, I'd probably change:

id TEXT PRIMARY KEY,
neo_reference_id TEXT

to

id INTEGER PRIMARY KEY,
neo_reference_id INTEGER

@mjovanc
Copy link
Member

mjovanc commented Oct 5, 2024

@chaseWillden Thanks for the PR. LGTM. However the code inside njord_examples will be changed at a later point. Need to fix the id field in the proc macro first.

But thanks a lot for the help!

@mjovanc mjovanc merged commit 7ec4a35 into njord-rs:master Oct 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants