Feature/upn epm #160
Feature/upn epm #160
Conversation
…gpn function for structure generation between groupr and errorr
…t digits, taken straight out of an NDI file)
There was a problem hiding this comment.
So overall, I think this looks good. It simplifies the input by making the group structures between ERRORR and GROUPR the same. It also adds a number of new group structures.
We will need to make a complementary Pull Request on the NJOY2016 manual.
| !------------------------------------------------------------------- | ||
| use mainio ! provides nsyso | ||
| use util ! provides error | ||
| use groupm ! provides gengpn |
There was a problem hiding this comment.
I like how we are now using the same thing in both ERRORR and GROUPR. No need to put this in twice!
| ! 18 xmas 172-group structure | ||
| ! 19 read in, supplemented with endf covariance grid | ||
| ! 18 xmas nea-lanl | ||
| ! 19 ecco 33-group structure |
There was a problem hiding this comment.
This is going to mess up someone's input. If they update and re-run their calculation, they are going to get different answers. Do we want to avoid using 19 to preserve existing capabilities?
There was a problem hiding this comment.
Whenever 19 is used, NJOY2016 will write a message out suggesting changing it to -1. In case the input still assumes the old 19 value, it will crash eventually because it'll try to interpret lines in the input file as the user defined structure.
| @@ -2471,6 +2498,1564 @@ subroutine gengpn | |||
| 1.252320e+07_kr,1.284030e+07_kr,1.349860e+07_kr,1.384030e+07_kr,& | |||
| 1.419070e+07_kr,1.454990e+07_kr,1.491820e+07_kr,1.568310e+07_kr,& | |||
| 1.648720e+07_kr,1.690460e+07_kr,1.733250e+07_kr,1.964030e+07_kr/) | |||
| real(kr),parameter::eg24(282)=(/& | |||
There was a problem hiding this comment.
I'm going to assume that these are the same values that were in error.f90.
|
PS. I've run the tests on my machine and they all pass. Let's wait and see what GitHub Actions reports. |
|
@wim @jlconlin @kahlerac |
Adding, and changing some existing, group identifiers in ERRORR and GROUPR.
Share code for uniform group labels in both GROUPR and ERRORR.
@jchsublet Will this affect your legacy NJOY2012 inputs? We're changing group numbers from the local upn created for the Agency several years ago.