Changed wpeg to wp-scripts #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed some files using prettier
improved readability of path variable usage in webpack config
nk-o
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project build logic has been completely changed. Now we are using wp-scripts.
I ran tests and visually checked the plugin in different places, but I could have missed something.
There is also a drawback in the process of working in developer mode: since the entry point is js files in hot dev mode, when updating scss, the part of the browser with these styles is not updated, since the connection method itself does not use JS files. In the future, it is necessary to import styles into JS, and if this is not possible, connect copies of these files separately.