Use jUnit5 based HiveMetastoreExtension with HiveTests, remove HiveMetastoeTest #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
reviewed
Nov 2, 2023
| @@ -60,8 +66,23 @@ public class HiveCreateReplaceTableTest extends HiveMetastoreTest { | |||
|
|
|||
| private String tableLocation; | |||
|
|
|||
| @RegisterExtension | |||
| public static final HiveMetastoreExtension HIVE_METASTORE_EXTENSION = | |||
There was a problem hiding this comment.
I made public as per reference
There was a problem hiding this comment.
The reference you pointed to defines the RegisterExtension interface via public @interface RegisterExtension but that doesn't mean we need to make it public here where it is used. That being said, it should be defined private here and in all other places (similar to how it's defined in the TestHiveCatalog from your other PR
nastra
reviewed
Nov 2, 2023
| public static final HiveMetastoreExtension HIVE_METASTORE_EXTENSION = | ||
| new HiveMetastoreExtension(DB_NAME, Collections.emptyMap()); | ||
|
|
||
| protected HiveCatalog catalog; |
There was a problem hiding this comment.
please also align all other tests the same way
nk1506
force-pushed
the
hive_tests_rf_fp
branch
2 times, most recently
from
40de512 to
3e5b450
Compare
nk1506
force-pushed
the
hive_tests_rf_fp
branch
from
3e5b450 to
0da58c5
Compare
nk1506
force-pushed
the
hive_tests_refactor
branch
2 times, most recently
from
5fdb2f5 to
13e4a4f
Compare
nk1506
force-pushed
the
hive_tests_refactor
branch
6 times, most recently
from
e95be19 to
7174c7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.