Mechanized infantry shoots friendly units that start firing their weapon

[blake8090]

Mods (complete and add to the following information):

• Arma 3: 2.08.148892
• CBA: 3.15.6
• LAMBS_DANGER: 2.5.4 dev

Description:

Suppose a unit is next to a separate group of friendly infantry with an armored vehicle (APC or tank).
When the unit starts shooting, the armored vehicle will order the infantry to shoot and kill the unit, despite being on the same side.

Steps to reproduce:

• Open Eden editor and select any terrain
• Place a rifleman (as player)
• Place another rifleman and any APC or tank and group them together. They should be the same side as the player
• Start the scenario
• Start shooting anywhere while moving
• Soon the friendly AI will start shooting at the player

Expected behavior:

When a friendly unit starts shooting, nearby friendly mechanized infantry should not target that unit.

Where did the issue occur?

• Singleplayer

Additional context:

• This occurs with all units of any side
• Interestingly enough, mechanized units will not shoot civilians

Videos:

Below is a link to a video showing how to reproduce this issue:
https://imgur.com/a/2lzAbrR

[blake8090]

Looks like I don't have write access to push a branch and open a pull request, but here's some notes on the technical fix:

Within fnc_brainVehicle.sqf, there's a block of code beginning on line 147 which has armored vehicles tell any available infantry in the group to engage enemy units:

// foot infantry support
private _units = [_unit] call EFUNC(main,findReadyUnits);
if !(_units isEqualTo [] && {_unit knowsAbout _dangerCausedBy < 2}) then {
    {
        _x setUnitPosWeak "MIDDLE";
        _x doWatch _dangerCausedBy;
        _x doTarget _dangerCausedBy;
        _x doFire _dangerCausedBy;
    } foreach _units;
};

The fix would be to add a check for the side before telling units to shoot. For example:

// foot infantry support
private _units = [_unit] call EFUNC(main,findReadyUnits);
private _validTarget = side _unit isNotEqualTo side _dangerCausedBy;
if (_validTarget && !(_units isEqualTo [] && {_unit knowsAbout _dangerCausedBy < 2})) then {
    {
        _x setUnitPosWeak "MIDDLE";
        _x doWatch _dangerCausedBy;
        _x doTarget _dangerCausedBy;
        _x doFire _dangerCausedBy;
    } foreach _units;
};

[nk3nny]

Excellent find and repo!

[nk3nny]

#321