Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating to use Stateless Component and PropTypes pkg (fixes #55) #56

Closed
wants to merge 1 commit into from
Closed

Updating to use Stateless Component and PropTypes pkg (fixes #55) #56

wants to merge 1 commit into from

Conversation

abritinthebay
Copy link

@abritinthebay abritinthebay commented Apr 14, 2017 •
edited
Loading

fixes #55

fitiskin
fitiskin suggested changes Apr 16, 2017
View reviewed changes
Copy link

@fitiskin fitiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update

export const CopyToClipboard = React.createClass({
  //
});

to

import createReactClass from 'create-react-class'

export const CopyToClipboard = createReactClass({
 //
});

nkbt
nkbt requested changes Apr 17, 2017
View reviewed changes
Copy link
Owner

@nkbt nkbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To many unrelated changes

src/Component.js

return React.cloneElement(elem, {
...sanitizedProps,
onClick: event => onClick(event, props)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not create new function on each render. Please, revert this PR to only change create class and prop types. This PR does too much.

@Dilatorily Dilatorily mentioned this pull request Apr 19, 2017
Merged
@nkbt
Copy link
Owner

nkbt commented Apr 20, 2017

Fixed by #58

@nkbt nkbt closed this Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkbt nkbt nkbt requested changes

@fitiskin fitiskin fitiskin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generates a warning about using deprecated feature in React.
3 participants
@abritinthebay @nkbt @fitiskin