[react-interval] Added typescript typings #131
Conversation
packages/interval/package.json
Outdated
| @@ -41,6 +42,7 @@ | |||
| "react": "^15.3.0 || ^16.0.0" | |||
| }, | |||
| "dependencies": { | |||
| "@types/react": "^16.0.2", | |||
There was a problem hiding this comment.
This react typings should be installed when other people will install this package.
There was a problem hiding this comment.
I'm not sure but maybe i should replace it to peer dependency
There was a problem hiding this comment.
So probably peerDeps then. We do not use TS and have no plans to, so installing unnecessary dependency does not seem quite right.
There was a problem hiding this comment.
Or even optionalDependencies would be better I reckon
The reason why it is not good to add such things into main deps is that they will live in a project after yarn install --production and will end up in docker images and also in licence reports...
There was a problem hiding this comment.
No, optional dependencies is not correct, because React typings is using inside this typings.
There was a problem hiding this comment.
I'm surprised how many people put @types/* into their production deps
https://github.com/search?utf8=✓&q=%27%40types%2Freact%27+extension%3Ajson&type=Code
This is quite sad tbh
| @@ -0,0 +1,13 @@ | |||
| /// <reference types="react" /> | |||
There was a problem hiding this comment.
this file needs to be added to files section of package.json, otherwise it will not be included into a package.
To check that locally you can run yarn pack (or npm pack) inside folder and then check contents of resulting react-interval-*.tgz
nkbt
changed the title
|
When i can expect release with this typings? |
|
@nkbt ?) |
ghost
mentioned this pull request
Added typescript typings