Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What project to use with Vite? #1982

Open
undergroundwires opened this issue Aug 21, 2023 · 1 comment
Open

What project to use with Vite? #1982

undergroundwires opened this issue Aug 21, 2023 · 1 comment

Comments

@undergroundwires
Copy link

As @nklayman recommends Vite and declared this project unmaintained/dead and Vue CLI is also dead, is there any official recommendation for us who will migrate? Or what setup did others in community find to be best?

I played around in Vite ecosystem but could not find anything closer to easiness of this plugin.
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this issue Aug 24, 2023
@undergroundwires
Migrate to electron-vite and electron-builder
75c9b51 
- Switch from deprecated Vue CLI plugin to `electron-vite` (see
  nklayman/vue-cli-plugin-electron-builder#1982)
- Update main/preload scripts to use `index.cjs` filenames to support
  `"type": "module"`, resolving crash issue (#233). This crash was
  related to Electron not supporting ESM (see electron/asar#249,
  electron/electron#21457).
- This commit completes migration to Vite from Vue CLI (#230).

Structure changes:

- Introduce separate folders for Electron's main and preload processes.
- Move TypeHelpers to `src/` to mark tit as accessible by the rest of
  the code.

Config changes:

- Make `vite.config.ts` reusable by Electron configuration.
- On electron-builder, use `--publish` flag instead of `-p` for clarity.

Tests:

- Add log for preload script loading verification.
- Implement runtime environment sanity checks.
- Enhance logging in `check-desktop-runtime-errors`.
@undergroundwires
Copy link
Author

undergroundwires commented Aug 25, 2023 •
edited
Loading

For those interested, I've migrated to Vite and electron-vite with electron-builder which comes with its pros and cons. My reference migration may help others (it includes tests and refactorings to isolate Vue CLI specific logic):

@undergroundwires undergroundwires mentioned this issue Sep 3, 2023
Closed
4 tasks
LarrMarburger added a commit to LarrMarburger/privacy.sexy that referenced this issue Nov 16, 2023
@LarrMarburger @undergroundwires
Migrate to electron-vite and electron-builder
c34130c 
- Switch from deprecated Vue CLI plugin to `electron-vite` (see
  nklayman/vue-cli-plugin-electron-builder#1982)
- Update main/preload scripts to use `index.cjs` filenames to support
  `"type": "module"`, resolving crash issue (#233). This crash was
  related to Electron not supporting ESM (see electron/asar#249,
  electron/electron#21457).
- This commit completes migration to Vite from Vue CLI (#230).

Structure changes:

- Introduce separate folders for Electron's main and preload processes.
- Move TypeHelpers to `src/` to mark tit as accessible by the rest of
  the code.

Config changes:

- Make `vite.config.ts` reusable by Electron configuration.
- On electron-builder, use `--publish` flag instead of `-p` for clarity.

Tests:

- Add log for preload script loading verification.
- Implement runtime environment sanity checks.
- Enhance logging in `check-desktop-runtime-errors`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@undergroundwires