Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache public addresses for re-dialing. #59

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Cache public addresses for re-dialing. #59

merged 1 commit into from
Mar 31, 2023

Conversation

billfort
Copy link
Contributor

  1. Add a new method getCachedPubAddrs to TunaSessionClient.
  2. Call getCachedPubAddrs at the beginning of getPubAddrsFromRemote to retrieve the cached address first.
  3. Need to export getCachedPubAddrs and sessionID before running the test case because the case is in a different package.

@billfort billfort force-pushed the pubaddrs branch 2 times, most recently from dc4f80c to 3f40dae Compare March 28, 2023 01:05
yilunzhang
yilunzhang reviewed Mar 28, 2023
View reviewed changes
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
message.go Show resolved Hide resolved
@billfort billfort force-pushed the pubaddrs branch 3 times, most recently from 221b841 to 9700d11 Compare March 28, 2023 20:02
yilunzhang
yilunzhang reviewed Mar 29, 2023
View reviewed changes
client.go Outdated Show resolved Hide resolved
yilunzhang
yilunzhang reviewed Mar 29, 2023
View reviewed changes
client.go Show resolved Hide resolved
@billfort billfort force-pushed the pubaddrs branch 2 times, most recently from f55845d to cc04290 Compare March 29, 2023 23:40
yilunzhang
yilunzhang reviewed Mar 30, 2023
View reviewed changes
client.go Outdated Show resolved Hide resolved
yilunzhang
yilunzhang reviewed Mar 30, 2023
View reviewed changes
client.go Show resolved Hide resolved
@billfort billfort force-pushed the pubaddrs branch 2 times, most recently from 6c2d96c to 7270a6a Compare March 30, 2023 22:32
yilunzhang
yilunzhang reviewed Mar 30, 2023
View reviewed changes
tests/tcp_test.go Outdated Show resolved Hide resolved
@billfort
Cache public addresses for re-dialing
3fc3ca3 
Signed-off-by: bill fort <fxbao@hotmail.com>
@yilunzhang yilunzhang merged commit cd63f16 into nknorg:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yilunzhang yilunzhang yilunzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billfort @yilunzhang