Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unittest for election.go #930

Merged
merged 2 commits into from
Mar 9, 2023
Merged

unittest for election.go #930

merged 2 commits into from
Mar 9, 2023

Conversation

bufrr
Copy link
Contributor

@bufrr bufrr commented Feb 23, 2023

No description provided.

@bufrr bufrr requested a review from yilunzhang February 23, 2023 03:23
yilunzhang
yilunzhang reviewed Feb 23, 2023
View reviewed changes
Copy link
Member

@yilunzhang yilunzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test here doesn't test voting logic or results. Each node needs to send out votes to other nodes. You also need to test different initial votes and check if they converge to the majority.

@bufrr bufrr force-pushed the election-tests branch 3 times, most recently from 3ea2d3d to 2170129 Compare February 27, 2023 06:41
@bufrr bufrr force-pushed the election-tests branch 11 times, most recently from 8899a30 to 39b6244 Compare March 1, 2023 11:06
yilunzhang
yilunzhang reviewed Mar 8, 2023
View reviewed changes
consensus/election/election_test.go Outdated Show resolved Hide resolved
consensus/election/election_test.go Outdated Show resolved Hide resolved
consensus/election/election_test.go Outdated Show resolved Hide resolved
consensus/election/election_test.go Outdated Show resolved Hide resolved
consensus/election/election_test.go Outdated Show resolved Hide resolved
consensus/election/election_test.go Show resolved Hide resolved
consensus/election/election_test.go Outdated Show resolved Hide resolved
consensus/election/election_test.go Outdated Show resolved Hide resolved
consensus/election/election_test.go Outdated Show resolved Hide resolved
consensus/election/election_test.go Outdated Show resolved Hide resolved
yilunzhang
yilunzhang reviewed Mar 8, 2023
View reviewed changes
consensus/election/election_test.go Outdated Show resolved Hide resolved
consensus/election/election_test.go Outdated Show resolved Hide resolved
consensus/election/election_test.go Show resolved Hide resolved
consensus/election/election_test.go Outdated Show resolved Hide resolved
consensus/election/election_test.go Outdated Show resolved Hide resolved
bufrr added 2 commits March 9, 2023 11:02
@bufrr
unittest for election.go
7a7c04a 
Signed-off-by: bufrr <chouyc.adam@gmail.com>

Signed-off-by: bufrr <chouyc.adam@gmail.com>
@bufrr
fix typo
36f3ded
@bufrr bufrr merged commit 551158c into nknorg:master Mar 9, 2023
@bufrr bufrr deleted the election-tests branch March 9, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yilunzhang yilunzhang yilunzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bufrr @yilunzhang