Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add websocket session connectTime to avoid deleting cached message too early #939

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

billfort
Copy link
Contributor

@billfort billfort commented Jun 6, 2023

  1. Add websocket session a member connectTime ;
  2. Set connectTime when session setClient ;
  3. When pop messageDeliveredCache message, check session connectTime to avoid deleting the message too early.

api/websocket/server/relay.go Outdated Show resolved Hide resolved
api/websocket/server/relay.go Outdated Show resolved Hide resolved
…o early

Signed-off-by: bill fort <fxbao@hotmail.com>
Copy link
Member

@yilunzhang yilunzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yilunzhang yilunzhang merged commit 2ae996a into nknorg:master Jun 8, 2023
@billfort billfort deleted the connecttime branch April 18, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants