Add OnOfferConnected channel for synchronize connected event for client #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yilunzhang
reviewed
May 9, 2024
api/webrtc/webrtc.go
Outdated
| @@ -99,8 +100,11 @@ func (c *Peer) Offer(label string) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| c.OnOfferConnected = make(chan struct{}, 1) | |||
There was a problem hiding this comment.
need to move this to constructer because very often people use it this way:
peer := NewPeer(...)
go func() { ... <-peer.OnOfferConnected ... }
peer.Offer()
so OnOfferConnected needs to be created when creating peer
yilunzhang
reviewed
May 9, 2024
api/webrtc/webrtc.go
Outdated
| dc.OnOpen(func() { | ||
| log.Debugf("Data channel %v has been opened\n", dc.Label()) | ||
| c.OnOfferConnected <- struct{}{} |
There was a problem hiding this comment.
need to use default to prevent blocking since Offer() can be called multiple times
Signed-off-by: billfort <fxbao@hotmail.com>
yilunzhang
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.