-
Notifications
You must be signed in to change notification settings - Fork 0
【フロントエンド】フォーマットツール移行 #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
【フロントエンド】フォーマットツール移行 #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
フロントエンドのフォーマットツールをPrettier + ESLintからBiomeに移行する変更です。
- ESLintとPrettierの設定ファイルを削除し、Biome設定を追加
- package.jsonのスクリプトとdevDependenciesをBiome用に更新
- TailwindCSSクラスの並び順やTypeScriptコードの改善を実施
Reviewed Changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| client/package.json | Biome関連のスクリプトと依存関係に更新 |
| client/biome.json | Biomeの設定ファイルを新規追加 |
| client/eslint.config.mjs | ESLint設定ファイルを削除 |
| client/.prettierrc | Prettier設定ファイルを削除 |
| client/.prettierignore | Prettierの除外設定ファイルを削除 |
| client/hooks/useWebSocket.ts | error型をunknownに変更、指数計算を**演算子に変更 |
| client/hooks/useTypingAnimation.ts | useEffectの依存配列を修正、インポート順序を調整 |
| client/hooks/api/useJoinRoom.ts | インポート文の並び順をアルファベット順に変更 |
| client/hooks/api/useCreateRoom.ts | インポート文の並び順をアルファベット順に変更 |
| client/components/*.tsx | TailwindCSSクラスの並び順、aria属性、React import等を修正 |
| client/app/room/**/*.tsx | React/Hooks使用方法、key属性、TailwindCSSクラス順序等を改善 |
client/app/room/[roomId]/_components/ingame/QuizTimerSection.tsx
Outdated
Show resolved
Hide resolved
Taiga2022
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
prettier->biomeに移行tailwindcssのclassソートする機能も追加
CI用にチェック専用のスクリプトを追加
pnpm formatpnpm lintで、リントエラーを解消なぜやったか
Note
Replaces Prettier/ESLint with Biome and applies automated formatting plus minor a11y/typing/react fixes across the client.
client/biome.json; updatepackage.jsonscripts to use Biome; remove Prettier/ESLint configs (.prettier*,eslint.config.mjs) and related deps.aria-hidden, remove unnecessary roles, addtype="button", and improve listkeys.useEffectdeps, useparseInt(..., 10), preferindexOfoverfindIndexin comparisons, and improve error typing/logic (e.g., exponentiation operator).Written by Cursor Bugbot for commit 2076626. This will update automatically on new commits. Configure here.