[CI] フロントエンドのCI改善 #133
Merged
[CI] フロントエンドのCI改善 #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with permission setting and concurrency setting
nkoji21
requested review from
Taiga2022,
pipapo-888 and
t-mase416
as code owners
There was a problem hiding this comment.
Pull Request Overview
フロントエンドCIの改善を行い、GitHub Actionsのベストプラクティスに従った設定を追加。
- timeout設定による無限実行の防止
- concurrency設定による同時実行制御
- permissions設定によるセキュリティ強化
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/frontend-ci.yml | timeout、permissions、concurrency設定を追加し、引用符を統一 |
| .github/workflows/backend-ci.yml | 引用符の統一のみ |
.github/workflows/frontend-ci.yml
Outdated
| - 'client/**' | ||
| - '.github/workflows/client-ci.yml' | ||
| - "client/**" | ||
| - ".github/workflows/client-ci.yml" |
There was a problem hiding this comment.
[必須] ワークフローファイル名が一致していません。ファイル名は 'frontend-ci.yml' ですが、paths では 'client-ci.yml' を監視しています。正しいファイル名 '.github/workflows/frontend-ci.yml' に修正してください。
Suggested change
| - ".github/workflows/client-ci.yml" | |
| - ".github/workflows/frontend-ci.yml" |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on November 12
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Taiga2022
approved these changes
Oct 10, 2025
Owner
Author
|
wwwwwwwww |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Actionsの設定項目を追加
timeout 5m の理由として、フロントエンドのFormatter LinterやBuildのみなら、1m 2m で終わるため
permission
このサイト勉強になった。
https://gihyo.jp/article/2024/10/good-practices-for-github-actions