Merge pull request #109 from indeyets/limit-recursion

findAssetsInViteManifest: Prevent recursive parsing of same ids
nksaraf · Jan 10, 2024 · a5271e0 · a5271e0
2 parents 4f793bd + b3deb3d
commit a5271e0
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/.changeset/famous-shrimps-switch.md b/.changeset/famous-shrimps-switch.md
@@ -0,0 +1,5 @@
+---
+"vinxi": patch
+---
+
+findAssetsInViteManifest: Prevent recursive parsing of same ids
diff --git a/packages/vinxi/lib/manifest/vite-manifest.js b/packages/vinxi/lib/manifest/vite-manifest.js
@@ -9,10 +9,16 @@
  * @returns Array of asset URLs
  */
 const findAssetsInViteManifest = (manifest, id, assetMap = new Map()) => {
+	const stack = [];
+
 	/**
 	 * @param {string} id
 	 */
 	function traverse(id) {
+		if (stack.includes(id)) {
+			return [];
+		}
+
 		const cached = assetMap.get(id);
 		if (cached) {
 			return cached;
@@ -21,6 +27,9 @@ const findAssetsInViteManifest = (manifest, id, assetMap = new Map()) => {
 		if (!chunk) {
 			return [];
 		}
+
+		stack.push(id);
+
 		const assets = [
 			...(chunk.assets || []),
 			...(chunk.css || []),
@@ -30,6 +39,9 @@ const findAssetsInViteManifest = (manifest, id, assetMap = new Map()) => {
 		const all = [...assets, ...imports].filter(Boolean);
 		all.push(chunk.file);
 		assetMap.set(id, all);
+
+		stack.pop();
+
 		return Array.from(new Set(all));
 	}
 	return traverse(id);