-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug?]: Dev server crashes when there is a syntax error solidjs/solid-start#1222 #100
Comments
I'd like to see the server revert and remain running until the change is corrected. This is particularly frustrating when using Auto Save in VSCode, as the code isn't necessary correct on each save (e.g. might be awaiting a closing tag). |
Fair. This needs to be fixed |
@nksaraf this is a deal breaker for my team, maybe you can point me to the problematic code and I will make a PR |
one issue is that because there are a few places your files get parsed, we have to handle the error case everywhere, which is fine, just needs some thorough trial and fixing. I had found some cases, for example the fsRouter parses files to check for exports, this probably errors out esbuild which is not handled gracefully. |
fix: catch errors in fs-router fixes #100
solidjs/solid-start#1222
The text was updated successfully, but these errors were encountered: