Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update path-to-regexp and don't override the params on the routes handler #368

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

jadedevin13
Copy link
Contributor

The context.params is being overridden here

const routes = [
...fileRoutes.map((route) => ({
...route,
handler: async (event, params) => {
const mod = await route.$handler.import();
event.context['params'] = params
return await mod.default(event);
},
})),
];

Copy link

codesandbox bot commented Sep 6, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Sep 6, 2024

🦋 Changeset detected

Latest commit: 4fd3e52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vinxi/router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 6, 2024

@jadedevin13 is attempting to deploy a commit to the Nikhil Saraf's projects Team on Vercel.

A member of the Team first needs to authorize it.

@nksaraf nksaraf merged commit 461a2da into nksaraf:main Oct 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants