Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support https with custom hostname in dev #390

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nikitavoloboev
Copy link

@nikitavoloboev nikitavoloboev commented Oct 3, 2024

Copy link

codesandbox bot commented Oct 3, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Oct 3, 2024

⚠️ No Changeset found

Latest commit: 1773fd7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vinxi-website ❌ Failed (Inspect) Oct 3, 2024 6:48pm

@ryansolid
Copy link
Collaborator

I was about to merge this but realized that you removed the resolveCertificate code. To be honest I'm not sure how it got there and if it is necessary but it suggests this PR is changing more than just exposing the hostname.

Is that intentional?

@AlexErrant
Copy link

AlexErrant commented Nov 16, 2024

FWIW, HTTPS with custom hostnames works in my own project. Uh, assuming here that custom hostname is just a modified /etc/hosts. Works for me with both dev and prod builds+serves, though I'm using wrangler pages dev dist/ --https-cert-path ./.cert/cert.pem --https-key-path ./.cert/key.pem for the "prod" serve.

In your code, you use devServer with host and https options, which aren't documented. Can you import the key/cert like I did and see if it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants